You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some common issues that don't fit there, so I'm opening a new bug report to lay out an idea how to fix this.
Workaround: disable dark theme altogether. gnome-calendar does this. This could be shipped pretty fast.
How to actually fix colors:
having good theme variant detection working
for environment variables: GTK_THEME=Adwaita:light
for GtkSettings key gtk-application-prefer-dark-theme
detect other themes which are not Adwaita but might be dark without specifying a dark variant
implement some logic to always have enough contrast to background but keep color tendencies, i.e. don't keep the exact RGBA value but allow dark green to become light green, etc.. See also this W3C spec on how to get contrast right
make sure to get all custom color codes set somewhere.
add style classes like installed to those GtkWidgets that need custom themes
This seems to be "the modern Gtk+ 3.x way".
This is nice and clean, but doesn't fix the problem for unknown dark themes without gtk-application-prefer-dark-theme set. Gtk+ people don't seem to care about that though.
If nobody objects, I'll be working on this.
The text was updated successfully, but these errors were encountered:
There are some minor issues with dark themes, e.g.:
There are some common issues that don't fit there, so I'm opening a new bug report to lay out an idea how to fix this.
Workaround: disable dark theme altogether. gnome-calendar does this. This could be shipped pretty fast.
How to actually fix colors:
GTK_THEME=Adwaita:light
gtk-application-prefer-dark-theme
Alternative approach as suggested by Gtk+ developer Matthias Clasen:
.installed { color: #darkgreen; }
installed
to those GtkWidgets that need custom themesThis seems to be "the modern Gtk+ 3.x way".
This is nice and clean, but doesn't fix the problem for unknown dark themes without
gtk-application-prefer-dark-theme
set. Gtk+ people don't seem to care about that though.If nobody objects, I'll be working on this.
The text was updated successfully, but these errors were encountered: