Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The margins between the header buttons are inconsistent #70

Closed
gitjod opened this issue Nov 1, 2015 · 5 comments
Closed

The margins between the header buttons are inconsistent #70

gitjod opened this issue Nov 1, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@gitjod
Copy link

gitjod commented Nov 1, 2015

The margin-end and the margin-right values for "GTKMenuButton - header_filters" need to be a value of 6 and not 0 in order for the the margins between the all the header buttons to look consistent

@timlau timlau self-assigned this Nov 4, 2015
@timlau timlau added this to the 4.1.x milestone Nov 4, 2015
@timlau
Copy link
Owner

timlau commented Nov 4, 2015

Thanks for reporting, I will look into this

@timlau
Copy link
Owner

timlau commented Nov 4, 2015

image

It is on purpose that the 2 search related buttons are grouped together

@gitjod
Copy link
Author

gitjod commented Nov 4, 2015

I thought perhaps that might be the case. I think a nicer implementation would be using a GtkToggleButton which when pressed shows the search box with the filters & search options exposed using a GtkArrow appearing in GtkTreeView. Probably best explained using a screenshot of the layout in Gnome-Music.

image

image

image

@gitjod gitjod closed this as completed Nov 4, 2015
@gitjod gitjod reopened this Nov 4, 2015
@timlau
Copy link
Owner

timlau commented Nov 5, 2015

Agree, the UI need some work to be more logic for the user

See discussio in #54

I will take a look at google music, looks like a good way to do it

@timlau timlau added the UI label Nov 5, 2015
@gitjod
Copy link
Author

gitjod commented Nov 5, 2015

Thanks Tim, I will close this issue as you have now opened #74

@gitjod gitjod closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants