From ad251cd7cf1658a44aeb494ea43a5e8fbb5d8460 Mon Sep 17 00:00:00 2001 From: Jacob Weinstock Date: Thu, 30 Jan 2025 10:09:20 -0700 Subject: [PATCH] Fix how we check for OSIE.BaseURL: The object that gets returned from Kubernetes seems to always come back non-nil. So we need to also check if the string is empty. Signed-off-by: Jacob Weinstock --- internal/ipxe/script/ipxe.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/ipxe/script/ipxe.go b/internal/ipxe/script/ipxe.go index 3d2f043a..d02523a6 100644 --- a/internal/ipxe/script/ipxe.go +++ b/internal/ipxe/script/ipxe.go @@ -287,7 +287,7 @@ func (h *Handler) defaultScript(span trace.Span, hw data) (string, error) { Retries: h.IPXEScriptRetries, RetryDelay: h.IPXEScriptRetryDelay, } - if hw.OSIE.BaseURL != nil { + if hw.OSIE.BaseURL != nil && hw.OSIE.BaseURL.String() != "" { auto.DownloadURL = hw.OSIE.BaseURL.String() } if hw.OSIE.Kernel != "" {