Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon appears twice in status bar sometimes [Race] #161

Open
IsaacHatton opened this issue Apr 6, 2024 · 1 comment
Open

Icon appears twice in status bar sometimes [Race] #161

IsaacHatton opened this issue Apr 6, 2024 · 1 comment
Labels
bug

Comments

@IsaacHatton
Copy link
Contributor

image
On beta v2.3000.1012596890 of WhatsApp, Chrome webstore version.
image

I'm finding it hard to reproduce, it happens sometimes, but other times it doesn't. I can't work out what causes it to happen.
@tomer8007
Copy link
Owner

This is a problem I've seen in the past and I fixed it previously. Per your report I see it's happening again. The following code should prevent adding the icon twice:

whatsapp-web-incognito/core/ui.js

Line 115 in 4717bc8

async function addIconIfNeeded()

It's probably a race as I wrote here:

whatsapp-web-incognito/core/ui.js

Line 111 in 4717bc8

// TODO: a race can make the icon added twice

@tomer8007 tomer8007 added the bug label Apr 6, 2024
@tomer8007 tomer8007 changed the title Icon appears twice in status bar Icon appears twice in status bar sometimes Apr 6, 2024
@tomer8007 tomer8007 changed the title Icon appears twice in status bar sometimes Icon appears twice in status bar sometimes [Race] Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomer8007 @IsaacHatton