Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtklib.h cleanup of defines, types etc #527

Open
reid-p opened this issue Mar 27, 2020 · 2 comments
Open

rtklib.h cleanup of defines, types etc #527

reid-p opened this issue Mar 27, 2020 · 2 comments

Comments

@reid-p
Copy link

reid-p commented Mar 27, 2020

Very nice library.

It'd be nice if rtklib tried to limit the defines, types etc that are public available via the rtklib.h header.
Limiting this to just whats required to call specific functions.

eg:

  • Prefix all #defines with RTK_ or something similar to prevent conflicts.
  • Prefix public functions with rtk_ or similar

I see at least one issue already raised about the lock / unlock defines that I'm also running into.

This would help alot with those linking directly to rtklib and help open up the usage of the library.

I'd be happy to help with this and have access to all the compilers needed to test changes, but before proceeding would need support from the project maintainers.

I've got a bit of time on my hands at the moment :(

@Mapoet
Copy link

Mapoet commented Aug 30, 2020

It is The Question you mentioned I also met when I want to merge all the *.c files into one file for easier developement.
As you did so many works on defines conflicts aspect, it is a better chose that you could start a new branch and maintain it(left a respo. with a url.), and you could ask for a branch merge on conflicts fixed one.

@Henkecool
Copy link

Issue #454 also mentions the same thing. The issues (and more) are fixed in pull request #579.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants