Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Get rid of the torchfl.models.core subpackage and related updates #21

Open
vivekkhimani opened this issue Feb 26, 2023 · 0 comments

Comments

@vivekkhimani
Copy link
Collaborator

Once we have a stable YAML support, we can get rid of the torchfl.models.core subpackage as we don't need to code-generate those repetitive files. The objects generated by those files can be achieved via YAML configs for the models.

Acceptance Criteria:

  • Get rid of the torchfl.models.core subpackage and the related reference from torchfl.* codebase.
  • Update the examples to not use those references. If anyone's willing to achieve the same functionality from the Python script, they can import a model from torchfl.sota and get it done.
  • Update the documentation:
    • README.md
    • modules information within the sphinx auto-generated docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant