Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fireplace#info barfs on shadow-cljs #366

Open
dhleong opened this issue Aug 20, 2019 · 2 comments
Open

fireplace#info barfs on shadow-cljs #366

dhleong opened this issue Aug 20, 2019 · 2 comments

Comments

@dhleong
Copy link
Contributor

dhleong commented Aug 20, 2019

Seems to be due to eg clojure.repl/special-doc not existing at the cljs repl. Deferring var resolution via ((resolve 'clojure.repl/special-doc) sym) instead of (#'clojure.repl/special-doc sym) seems to fix it for the common case, but of course would still explode if it was actually a special-symbol, for example...

Example error when using K:
Screen Shot 2019-08-19 at 9 38 41 PM

@tpope
Copy link
Owner

tpope commented Aug 20, 2019

I consider cider-nrepl mandatory for cljs. I think the appropriate fix is a better error message.

@dhleong
Copy link
Contributor Author

dhleong commented Aug 20, 2019

Works for me. I posted this pretty late in a long bus trip and didn't think about not having cider-nrepl set up on that laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants