Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable possibility to ban synced users #43

Open
l0kix2 opened this issue Sep 5, 2024 · 4 comments
Open

Enable possibility to ban synced users #43

l0kix2 opened this issue Sep 5, 2024 · 4 comments

Comments

@l0kix2
Copy link
Collaborator

l0kix2 commented Sep 5, 2024

Currently if you ban managed user, identity-sync will unban it on next iteration. This must be fixed with some extra parameter in adsync user state so it could distinguish extranlly banned users from users banned by its own code.

@zlobober
Copy link
Collaborator

zlobober commented Sep 5, 2024

Maybe we can simply say that the automation never unbans any user? What are the normal scenarios when it is useful to automatically unban somebody?

@l0kix2
Copy link
Collaborator Author

l0kix2 commented Sep 5, 2024

We ban them for week for example before deleting, so if user is back again (was deleted by accident or some other unexpected error) we unban him. But of course we can only ban and never unban and if such accidental removal happens we will have to unban manually

@zlobober
Copy link
Collaborator

zlobober commented Sep 5, 2024

I think it is just fine to always unban manually, as the expected rate of erroneously banned users is low. This would be much simpler than introducing various kinds of bans.

@l0kix2
Copy link
Collaborator Author

l0kix2 commented Sep 5, 2024

Yes, ok, makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants