Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeTrafficSplitsLoop in pkg/topology/builder.go is confusingly named #586

Closed
dtomcej opened this issue May 15, 2020 · 0 comments · Fixed by #606
Closed

removeTrafficSplitsLoop in pkg/topology/builder.go is confusingly named #586

dtomcej opened this issue May 15, 2020 · 0 comments · Fixed by #606
Assignees
@dtomcej
Milestone
v1.3

Comments

@dtomcej
Copy link
Contributor

dtomcej commented May 15, 2020

Feature Request

Proposal

removeTrafficSplitsLoop in pkg/topology/builder.go is confusingly named, and should be either renamed, or reworked in order to be clearer about what it is doing:

#564 (comment)

Background

Having clear code objectives makes debugging and refactoring easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtomcej dtomcej

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

Rename method and vars for loop removal dtomcej/maesh
2 participants
@dtomcej @traefiker