Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty manifold module #59

Open
JustinShenk opened this issue Feb 7, 2021 · 3 comments
Open

Empty manifold module #59

JustinShenk opened this issue Feb 7, 2021 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@JustinShenk
Copy link
Collaborator

https://github.com/traja-team/traja/blob/master/traja/models/manifold.py is empty and has no test coverage. Please motivate inclusion or remove it.

@JustinShenk JustinShenk added the help wanted Extra attention is needed label Feb 7, 2021
@Saran-nns
Copy link
Member

Saran-nns commented Feb 7, 2021

we have a new issue open for it. #58. Dimensionality reduction and visualization of the latent space has to be in manifold.py. As mentioned in the comments, this has to be integrated with the manifolds module at scikit-learn https://scikit-learn.org/stable/modules/manifold.html.

@JustinShenk
Copy link
Collaborator Author

JustinShenk commented Feb 7, 2021 via email

@WolfByttner
Copy link
Contributor

Shall we remove the code from Master then? The code can be restored when someone is ready to work on it (the power of Git).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants