Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #68

Open
1 of 17 tasks
Saran-nns opened this issue Feb 9, 2021 · 1 comment
Open
1 of 17 tasks

Linting #68

Saran-nns opened this issue Feb 9, 2021 · 1 comment
Assignees

Comments

@Saran-nns
Copy link
Member

Saran-nns commented Feb 9, 2021

Analyze source code for bugs and style errors.
If you lint any module from any branch, please mark them done below

  • visualizer
  • optimizer
  • losses
  • train
  • utils
  • inference
  • predictive_model/ae
  • predictive_models/lstm
  • generative_models/vae
  • generative_models/vaegan
  • base_models/MLPClassifier
  • base_models/MLPRegressor
  • dataset/dataset
  • dataset/example
  • dataset/generator
  • dataset/geolife
  • dataset/pedestrian
@JustinShenk
Copy link
Collaborator

JustinShenk commented Feb 9, 2021

I added 'pre-commit' to requirements/dev.txt with flake8 and black, and ran pre-commit run --all-files. I skipped PR process and pushed it to master at b145684, though PR is the standard procedure. There are several errors worth attending to, like variable name complexity:

traja/tests/test_dataset.py:71:1: C901 'test_time_based_sampling_dataloaders_with_short_stride_do_not_overlap' is too complex (20)

Installing pre-commit locally will now run black and flake8 on staged files.

Also highly recommended is to add flake8 linter (and black) to Visual Studio Code or whichever IDE you use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants