Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trading - server endpoint quotes is called on pages where it shouldn't be #16374

Closed
FreeWall opened this issue Jan 15, 2025 · 1 comment · Fixed by #16450
Closed

Trading - server endpoint quotes is called on pages where it shouldn't be #16374

FreeWall opened this issue Jan 15, 2025 · 1 comment · Fixed by #16450
Assignees
Labels
bug Something isn't working as expected +Invity Related to Invity project

Comments

@FreeWall
Copy link
Member

Describe the bug
Coinmarket server endpoint quotes is called periodically on pages where it shouldn't be, i.e. on coinmarket/exchange/confirm page.

Info:
Suite version: web 25.1.0

How to reproduce
Steps to reproduce the behavior:

  1. Go to Buy/Sell/Swap page
  2. Select an offer (continue to confirm page)
  3. quotes request is made every 30 seconds or so
@FreeWall FreeWall added +Invity Related to Invity project bug Something isn't working as expected labels Jan 15, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Jan 15, 2025
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jan 20, 2025
@bosomt
Copy link
Contributor

bosomt commented Jan 22, 2025

QA OK

waited in confirm and after confirm of receive address, no more quotes in network tab during waiting

Info:

  • Suite version: web 25.2.0 (551157e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1920x1080
  • Device: Trezor T2B1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected +Invity Related to Invity project
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

3 participants