Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC] [AC] [Feature] [Core] Config for hired bots to not engage in combat unless they are in a party #954

Open
3 tasks done
Zerkenn opened this issue Dec 16, 2024 · 2 comments
Labels
enhancement New feature or request question This issue is in fact a question

Comments

@Zerkenn
Copy link

Zerkenn commented Dec 16, 2024

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

  • I understand that my issue may get closed without notice if I intentionally remove or skip any mandatory* field
  • This is NOT a bug/crash report
  • I've searched the bugtracker for similar questions/requests including closed ones

Description

I request a config that prevents bots from attacking/engaging in combat unless the bot is in a group with the bot owner.

This config will make it so when using bots in the open world they will not help with combat unless they are grouped with their owner so money and xp reductions are always applied when bots are assisting the player.

TrinityCore or AzerothCore

Both

Core rev. hash/commit

No response

Operating system

No response

@Zerkenn Zerkenn added enhancement New feature or request question This issue is in fact a question labels Dec 16, 2024
@trickerer
Copy link
Owner

How about you just set NpcBot.XpReduction.Blizzlike.GroupOnly to 0 instead of trying to confuse the players as to why their bots aren't doing anything?

@Zerkenn
Copy link
Author

Zerkenn commented Dec 17, 2024

How about you just set NpcBot.XpReduction.Blizzlike.GroupOnly to 0 instead of trying to confuse the players as to why their bots aren't doing anything?

My current config:


NpcBot.XpReduction.Amount              = 0
NpcBot.XpReduction.StartingNumber      = 2
NpcBot.XpReduction.Blizzlike.Enable    = 1
NpcBot.XpReduction.Blizzlike.GroupOnly = 0

Currently setting NpcBot.XpReduction.Blizzlike.GroupOnly = 0 appears to not work correctly. If you hire a bot and it is not in your party xp is still not being reduced.

For the best gameplay balance here is how I think it should work.

  • When not in a group, blizzlike party xp reduction should apply to the player based on how many bots the player has hired and are within server xp distance.
  • When in a group, it works in a blizzlike way where bots and players count towards normal xp reduction (However this is still a issue because the player could invite 1 of their bots and leave the others out of their group and then they would only get the xp reduction of 1 player/bot even though all of the others outside the party are still helping them.)

This new Blizzlike feature is nice but i'm trying to balance it just right. Previously we have been using:

NpcBot.XpReduction.Amount              = 18
NpcBot.XpReduction.StartingNumber      = 1

It was close to blizzlike but not great. And the other issue was the xp reduction amount was based off the player who had hired the most bots regardless of the actual bots in the party/dungeon with you. If player 1 hired 4 bots and player 2 hired 1 bot and both joined a party and player 1 invited 2 of their bots and player 2 invited their 1 bot their bots, when inside the dungeon even thought there was only 3 bots in the group the xp reduction was 18x4 = 72% for everyone because player 1 had 4 hired bots.

I'm not sure how you intend for NpcBot.XpReduction.Blizzlike.GroupOnly = 0 to work, but if it is intended to count all bots including other players hired bots that are within server xp distance around the player into the blizzlike xp reduction that could probably work.

This is why in the current situation I suggested the config to make it so bots don't assist in combat unless you are in the same party/raid group with them. This would make it so blizzlike xp reduction works perfectly anytime bots are assisting you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question This issue is in fact a question
Projects
None yet
Development

No branches or pull requests

2 participants