Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate CI failures of Navier-Stokes convergence tests #1729

Closed
ranocha opened this issue Nov 10, 2023 · 6 comments · Fixed by #1728
Closed

Investigate CI failures of Navier-Stokes convergence tests #1729

ranocha opened this issue Nov 10, 2023 · 6 comments · Fixed by #1728
Labels
bug Something isn't working testing

Comments

@ranocha
Copy link
Member

ranocha commented Nov 10, 2023

See, e.g., https://github.com/trixi-framework/Trixi.jl/actions/runs/6822444380/job/18554514929#step:7:4567

Can anybody reproduce this locally?
@ranocha ranocha added bug Something isn't working testing labels Nov 10, 2023
@ranocha ranocha pinned this issue Nov 10, 2023
@jlchan
Copy link
Contributor

jlchan commented Nov 10, 2023

It's DGMulti failing, right? I'll take a look this afternoon.

@jlchan jlchan linked a pull request Nov 10, 2023 that will close this issue
fix failing DGMultiMesh and Compressible Navier-Stokes convergence tests #1728
Merged
@ranocha
Copy link
Member Author

ranocha commented Nov 10, 2023 •
edited
Loading

I think so, yes. But my best guess is that it may be related to updates of upstream packages since it fails consistently in CI since a few days ago...
Thanks a lot!

@sloede
Copy link
Member

sloede commented Nov 10, 2023

@jlchan maybe run one or two tests for longer and check if there are eg small differences in the calculation of dt. If the final result is still similar, I'd be OK to just update the reference errors

@jlchan
Copy link
Contributor

jlchan commented Nov 10, 2023

Will do. Prob also good to check to see if we get the expected convergence rates

@jlchan jlchan closed this as completed Nov 10, 2023
@jlchan jlchan reopened this Nov 10, 2023
@jlchan
Copy link
Contributor

jlchan commented Nov 10, 2023 •
edited
Loading

Hm, this isn't DGMulti failing - it's TreeMesh and P4estMesh. Moreover, I think it's a real failure - the error stagnates at around .07 while DGMulti error decreases to 5e-6 for an equivalent resolution. Still investigating.

@jlchan
Copy link
Contributor

jlchan commented Nov 10, 2023 •
edited
Loading

I think I found it - it looks like the formatting PR #1531 removed some important code for those specific elixirs

Trixi.jl/examples/tree_2d_dgsem/elixir_navierstokes_convergence.jl

Lines 168 to 169 in 541a510

-
-

@jlchan jlchan closed this as completed Nov 11, 2023
@ranocha ranocha unpinned this issue Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix failing DGMultiMesh and Compressible Navier-Stokes convergence tests jlchan/Trixi.jl
3 participants
@jlchan @sloede @ranocha