From f0ea722ee38e70719d2e48c4b0bbbe06c246bb6e Mon Sep 17 00:00:00 2001 From: tsantalis Date: Wed, 8 Jan 2025 16:41:35 -0500 Subject: [PATCH] Eliminate Move Method false positives in commit https://github.com/hibernate/hibernate-search/commit/67c3402d72dfb225ae67c57f4bb3de684eb42c28 --- src/main/java/gr/uom/java/xmi/diff/UMLClassBaseDiff.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/gr/uom/java/xmi/diff/UMLClassBaseDiff.java b/src/main/java/gr/uom/java/xmi/diff/UMLClassBaseDiff.java index 4ebd2eadb..846494fcb 100644 --- a/src/main/java/gr/uom/java/xmi/diff/UMLClassBaseDiff.java +++ b/src/main/java/gr/uom/java/xmi/diff/UMLClassBaseDiff.java @@ -2046,7 +2046,8 @@ private void updateMapperSet(TreeSet mapperSet, UMLOpera UMLOperationBodyMapper operationBodyMapper = new UMLOperationBodyMapper(removedOperation, addedOperation, this); List totalMappings = new ArrayList(operationBodyMapper.getMappings()); int mappings = operationBodyMapper.mappingsWithoutBlocks(); - if(mappings > 0 || (delegatesToAnotherRemovedOperation(removedOperation) && addedOperation.getBody() != null && addedOperation.stringRepresentation().size() > 3) || (removedOperation.getName().equals(addedOperation.getName()) && removedOperation.getBody() != null && addedOperation.getBody() != null)) { + if(mappings > 0 || (delegatesToAnotherRemovedOperation(removedOperation) && addedOperation.getBody() != null && addedOperation.stringRepresentation().size() > 3) || (removedOperation.getName().equals(addedOperation.getName()) && removedOperation.getBody() != null && addedOperation.getBody() != null) || + removedOperation.equalSignatureForAbstractMethods(addedOperation)) { boolean zeroNonMapped = operationBodyMapper.getNonMappedLeavesT1().size() == 0 && operationBodyMapper.getNonMappedLeavesT2().size() == 0 && operationBodyMapper.getNonMappedInnerNodesT1().size() == 0 && operationBodyMapper.getNonMappedInnerNodesT2().size() == 0 && removedOperation.hasTestAnnotation() && addedOperation.hasTestAnnotation();