Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential statement mapping (Move And Rename Method) #427

Open
pedramnoori opened this issue Mar 26, 2023 · 0 comments
Open

Potential statement mapping (Move And Rename Method) #427

pedramnoori opened this issue Mar 26, 2023 · 0 comments

Comments

@pedramnoori
Copy link

Problem

Two statements reported as non-mapped has the potential to match

Commit

Here

Refactoring

Move And Rename Method private getFlags(edgePointer long, reverse boolean) : long from class com.graphhopper.storage.GraphHopperStorage to package getFlags_(tmpPropAccess InternalGraphPropertyAccess, edgePointer long, reverse boolean) : long from class com.graphhopper.storage.BaseGraph

Description

There is a pair of statements reported as non-mapped leaves:
1- return reverseFlags(edgePointer,res); Line 710, parent version
2- resFlags=tmpPropAccess.reverseFlags(edgePointer,resFlags); Line 686, child version

Based on the manual validation of the refactoring, these two statements can match together. The changes are justifiable by a Rename Variable refactoring, and the mechanics of the Move Method refactoring.

@tsantalis tsantalis changed the title Potential statement mapping Potential statement mapping (Move And Rename Method) Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant