Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing block mapping #464

Open
pedramnoori opened this issue May 8, 2023 · 0 comments
Open

Missing block mapping #464

pedramnoori opened this issue May 8, 2023 · 0 comments

Comments

@pedramnoori
Copy link

Problem

Missing a block mapping within an Extract and Move Method refactoring

Commit

google/guava@31fc192

Refactoring

Extract And Move Method public tryParse(string String, radix int) : Long extracted from package tryParse(string String, radix int) : Integer in class com.google.common.primitives.Ints & moved to class com.google.common.primitives.Longs

Description

There is only one block statement reported in the nonMappedInnerNodesT2. According to the manual validation and the discussion we had in the meeting, the reported refactoring is correct. Even though the tryParse method already exist within the destination class, it's not a perfect match for the target method. In fact, the method tryParse(string String, radix int) is truly extracted and moved from Ints to Longs class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant