Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detected method extraction is reported twice #686

Closed
victorgveloso opened this issue Mar 20, 2024 · 3 comments
Closed

Detected method extraction is reported twice #686

victorgveloso opened this issue Mar 20, 2024 · 3 comments

Comments

@tsantalis
Copy link
Owner

@victorgveloso
I checked all refactorings and they are correct.
The same method createMessageTask is extracted from multiple different tests.

@pouryafard75
new is not getting matched

image

@victorgveloso
Copy link
Contributor Author

@pouryafard75 just explained me that RMiner reports one extracted method refactoring for each method invocation and that is the intended behaviour.

I don't know if that changed recently, but getExtractedOperationInvocations returns an ArrayList hence why I assumed that array could contain multiple values. Instead it always contain a single invocation as the refactoring is split by invocation.

@tsantalis
Copy link
Owner

Resolved in PR #689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants