Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort files in a tree / similar to GitHub #702

Closed
koppor opened this issue Apr 11, 2024 · 12 comments
Closed

Sort files in a tree / similar to GitHub #702

koppor opened this issue Apr 11, 2024 · 12 comments

Comments

@koppor
Copy link

koppor commented Apr 11, 2024

My case: https://github.com/JabRef/jabref/pull/11180/files

I want to add review comments on files. Since there are 30 files, it is hard to find the other file if the ordering of files does not match. I would like to see the same ordering in RFM and in GitHub

GitHub:

image

RFM:

image

I think, the GitHub ordering is good, because it orders first as folders, then as file names. Maybe, RFM can adapt that ordering, too?

pouryafard75 added a commit to pouryafard75/RM-ASTDiff that referenced this issue Apr 15, 2024
@tsantalis tsantalis reopened this Apr 15, 2024
@tsantalis
Copy link
Owner

@koppor
This is how the updated UI looks like. We are still working on it to make it more functional and user-friendly.

Screenshot from 2024-04-15 19-42-03

@tsantalis
Copy link
Owner

@koppor
BTW, you can update your docker image from https://hub.docker.com/r/tsantalis/refactoringminer
We release on every Monday midnight a new image from the latest commit of the project.

@tsantalis
Copy link
Owner

@koppor

UI update with folder icons instead of bullets

Screenshot from 2024-04-16 16-36-29

@koppor
Copy link
Author

koppor commented Apr 16, 2024

@tsantalis Nice! - The indent could be less, then the white space could be used to display additional information. Maybe a next step could be to be more similar to github and show the diff on the right side of the tree.

Maybe interesting link: Feedback to the GitHub tree is collected at https://github.com/orgs/community/discussions/12341.

@tsantalis
Copy link
Owner

@koppor

Tree file view updates:

  • The folders can be expanded and collapsed
  • The files are decorated with icons showing if the file is modified or moved/renamed

Screenshot from 2024-04-20 02-36-03

Screenshot from 2024-04-20 02-37-50

@tsantalis
Copy link
Owner

  • Add vertical lines to show clearly the nesting of folders

image

@koppor
Copy link
Author

koppor commented Apr 24, 2024

Looks nice!

Intuitively, I clicked on the file name and nothing happens. I was expecting that the MonacoDiff shows up.

@tsantalis
Copy link
Owner

@koppor
This is the way we would like eventually to do it. Clicking on the file name should open the diff.
And also have the file tree as a left-side panel, so that the diff loads directly on the right side.

I will try as a temporary solution to open the monaco diff when clicking on the name.

@tsantalis
Copy link
Owner

@koppor
Added hypelink on the file name opening the monaco diff by default.

Screenshot from 2024-04-25 21-38-33

@koppor
Copy link
Author

koppor commented Apr 26, 2024

@tsantalis Thank you for the quick action taken. I always need to wait until Mondays for a new Docker build to try out. 😅

@tsantalis
Copy link
Owner

@koppor
I also updated the way the renamed files are displayed. I will push a new Docker images in a few minutes

Screenshot from 2024-04-26 05-25-32

@koppor
Copy link
Author

koppor commented May 27, 2024

To keep the number of issues low, I close this.

The current solution works good. The "endless scrolling" requirement is outlined at #672 (comment) and will behandled there.

@koppor koppor closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants