-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper handling of newlines when parsing comments #725
Comments
It's really cool the tool finds that This is a challenging case, but our tool did pretty well !! |
Merge Method [private routeLoggingToSlf4J() : void, private addLogToDisk() : void] to private initLogging(args String[]) : void in class org.jabref.Launcher Inline Method private initializeLogger() : void inlined to private initLogging(args String[]) : void in class org.jabref.Launcher
Thank you for continuosly improving the tool! - (I still miss the connecting lines (#703 (comment)) to see which block went where). I am still used to the IntelliJ "Resolve Conflicts" dialog ^^) |
@koppor @pouryafard75 |
4 of our tests failed after this update. org.opentest4j.AssertionFailedError: Failed for belaban/JGroups@f153375 , srcFileName: src/org/jgroups/auth/FixedMembershipToken.java ==> expected: <112842> but was: <113219> org.opentest4j.AssertionFailedError: Failed for spring-projects/spring-security@fcc9a34 , srcFileName: web/src/main/java/org/springframework/security/web/context/SaveContextOnUpdateOrErrorResponseWrapper.java ==> expected: <442150> but was: <443825> org.opentest4j.AssertionFailedError: Failed for addthis/hydra@7fea4c9 , srcFileName: hydra-main/src/main/java/com/addthis/hydra/job/spawn/SpawnBalancer.java ==> expected: <2844989> but was: <2846125> org.opentest4j.AssertionFailedError: Failed for AsyncHttpClient/async-http-client@f01d861 , srcFileName: api/src/test/java/org/asynchttpclient/oauth/OAuthSignatureCalculatorTest.java ==> expected: <219056> but was: <221438> org.opentest4j.AssertionFailedError: Failed for nutzam/nutz@de7efe4 , srcFileName: src/org/nutz/dao/util/Daos.java ==> expected: <1103701> but was: <1103968> |
This issue has been fixed to perfection! |
I am investigating another "interesting" PR (JabRef/jabref-koppor#687)
I noticed that comments are now handled. Thank you for that!
It would be great if RefactoringMinor could handle newlines. Currently, if "only" line breaks change, it is determined as deleted/new - not as moved:
The text was updated successfully, but these errors were encountered: