Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on non-touched lines should also scroll #726

Closed
koppor opened this issue May 27, 2024 · 3 comments
Closed

Click on non-touched lines should also scroll #726

koppor opened this issue May 27, 2024 · 3 comments

Comments

@koppor
Copy link

koppor commented May 27, 2024

Currently, when clicking on deleted and inserted, the views sync.

When clicking on non-touched lines, nothing happens.

Wish: Clicking on non-touched lines, the other view should scroll to that position.

(This is a workaround for #672)
pouryafard75 added a commit to pouryafard75/RM-ASTDiff that referenced this issue May 29, 2024
@pouryafard75
ASTDiff: (GUI) Monaco diff scroll for non action associated subtrees (F…
824acbc 
…ixes tsantalis#726)
pouryafard75 added a commit to pouryafard75/RM-ASTDiff that referenced this issue May 29, 2024
@pouryafard75
ASTDiff: (GUI) Vanilla diff scroll for non action associated subtrees (…
683feb0 
…Fixes tsantalis#726)
pouryafard75 added a commit to pouryafard75/RM-ASTDiff that referenced this issue May 29, 2024
@pouryafard75
ASTDiff: (GUI) Vanilla diff scroll for non action associated subtrees (…
6b9f8b8 
…Fixes tsantalis#726)
tsantalis pushed a commit that referenced this issue May 29, 2024
@pouryafard75 @tsantalis
ASTDiff: (GUI) Vanilla diff scroll for non action associated subtrees (…
6c637a6 
…Fixes #726)
@tsantalis
Copy link
Owner

@koppor

Double-clicking on non-touched lines auto-scrolls and aligns the editors.

@koppor
Copy link
Author

koppor commented May 29, 2024

@koppor

Double-clicking on non-touched lines auto-scrolls and aligns the editors.

Oh, and for the touched ones a single click? Why this UI difference? 😅

@tsantalis
Copy link
Owner

@pouryafard75
Could you please clarify why double-click for unchanged lines and not single-click?

I tested the new feature, and it seems now that both changed and unchanged lines need a double-click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koppor @tsantalis