Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sync() safe to be called even offline #1919

Open
penberg opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1923
Open

Make sync() safe to be called even offline #1919

penberg opened this issue Jan 15, 2025 · 0 comments · May be fixed by #1923
Labels
enhancement New feature or request offline writes

Comments

@penberg
Copy link
Collaborator

penberg commented Jan 15, 2025

Let's look into making sync() deal with errors when offline and simply report that no frames got synced. Could be easier for applications to use the API.
@penberg penberg added enhancement New feature or request offline writes labels Jan 15, 2025
levydsa added a commit to levydsa/libsql that referenced this issue Jan 17, 2025
@levydsa
fix: prevent reporting http errors in sync_offline
5cd13fa 
resolves tursodatabase#1919
levydsa added a commit to levydsa/libsql that referenced this issue Jan 17, 2025
@levydsa
fix: prevent reporting http errors in sync_offline
3cc70a2 
resolves tursodatabase#1919
levydsa added a commit to levydsa/libsql that referenced this issue Jan 17, 2025
@levydsa
fix: prevent reporting http errors in sync_offline
eaccfee 
resolves tursodatabase#1919
@levydsa levydsa linked a pull request Jan 17, 2025 that will close this issue
Open
levydsa added a commit to levydsa/libsql that referenced this issue Jan 17, 2025
@levydsa
fix: prevent reporting http errors in sync_offline
111c277 
resolves tursodatabase#1919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request offline writes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent reporting HttpDispatch errors in sync_offline levydsa/libsql
1 participant
@penberg