Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console prompt should indicate uncommitted changes #167

Open
flyingsilverfin opened this issue Aug 2, 2021 · 2 comments · Fixed by #178
Open

Console prompt should indicate uncommitted changes #167

flyingsilverfin opened this issue Aug 2, 2021 · 2 comments · Fixed by #178

Comments

@flyingsilverfin
Copy link
Member

To improve our console UX, we can modify the transaction prompt with for example a * at the end to indicate whether the transaction has uncommitted changes.

This may end up being a state variable that is switched when a write query is performed - including define/undefine, and cleared on commit.

Note that match-insert and match-delete aren't necessarily inserting or deleting anything as the match can fail. This links with issue #166 , as we can modify this state when the user confirms they want to proceed with a insert/delete.

@flyingsilverfin
Copy link
Member Author

@alexjpwalker pinged you in this because it's linked to the other issue :) this one should be relatively easy

@alexjpwalker
Copy link
Member

Seems like we no longer show the uncommitted transaction indicator in 3.0:

> transaction blorg schema
blorg::schema> define entity person;

Success
blorg::schema> exit

@alexjpwalker alexjpwalker reopened this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants