Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate the updated kotlin_deps #424

Open
dmitrii-ubskii opened this issue Feb 23, 2023 · 1 comment
Open

Propagate the updated kotlin_deps #424

dmitrii-ubskii opened this issue Feb 23, 2023 · 1 comment
Assignees

Comments

@dmitrii-ubskii
Copy link
Member

We should make sure all active repositories in the vaticle org updated dependencies since the kotlin breaking change.

In BUILD:

load("@io_bazel_rules_kotlin//kotlin:core.bzl", "define_kt_toolchain")
define_kt_toolchain(
    name = "kotlin_toolchain_strict_deps",
    api_version = "1.7",
    language_version = "1.7",
    experimental_strict_kotlin_deps = "error",
)

In WORKSPACE:

# Load Kotlin
load("@vaticle_dependencies//builder/kotlin:deps.bzl", kotlin_deps = "deps")
kotlin_deps()
load("@io_bazel_rules_kotlin//kotlin:repositories.bzl", "kotlin_repositories", "kotlinc_version")
kotlin_repositories()
load("@io_bazel_rules_kotlin//kotlin:core.bzl", "kt_register_toolchains")
kt_register_toolchains()
register_toolchains("//:kotlin_toolchain_strict_deps")
@alexjpwalker
Copy link
Member

We decided not to do this all in "one go" at the time because there are so many repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants