Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RequestID with a tuple of TransactionID + RequestSeq #178

Open
dmitrii-ubskii opened this issue Jan 31, 2023 · 1 comment
Open
Assignees

Comments

@dmitrii-ubskii
Copy link
Member

Problem to Solve

UUIDv4 generation is quite costly, and generating a new one for each query in rapid succession (during e.g. data ingestion) can make it a bottleneck.

Proposed Solution

Generate UUID once for the transaction and append a sequence number for each request in a transaction, or move away from uuids altogether.

@alexjpwalker
Copy link
Member

alexjpwalker commented Jan 31, 2023

SequenceID makes sense. The current UUID implementation is a lazy, suboptimal way of generating unique IDs without needing to maintain additional client-side state.

TransactionID shouldn't be necessary as each bidirectional stream is scoped to a single Transaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants