Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a note here re: OS X #9

Open
hrbrmstr opened this issue Jan 10, 2016 · 4 comments
Open

Making a note here re: OS X #9

hrbrmstr opened this issue Jan 10, 2016 · 4 comments

Comments

@hrbrmstr
Copy link

fails hard even with the C++ YAML lib installed. Will post logs in a bit.

However…

Why not read the YAML file with R (via the yaml package) and pass an R data structure into Rcpp? It's not like the UA YAML file is huge (so it's not going to really save time) and it would remove something you'd no doubt have to make a download-and-install library as part of the pkg installation process (== ugh).

Also, an alternative to getting C++ regex working is to ask the stringi folks to expose a cpl functions directly (i.e. just use stringi regexes). I'll still keep poking at the example icu code you slack'd tho.

@Ironholds
Copy link
Contributor

(Any luck getting the stringi example to work, btw?)

No big reason except that it's a pretty big refactor I haven't gotten around to, tbh.

@Ironholds
Copy link
Contributor

@hrbrmstr so I'm now working on this and I've got everything working with one exception: C++11 uses a different regex engine to Boost :|. If you find a PCRE to ECMAScript engine, or have any smart ideas, lemme know.

@bearloga
Copy link
Contributor

bearloga commented Jul 7, 2017

FWIW, using the latest version of libyaml-cpp (via brew install yaml-cpp) and the latest version uaparser on macOS 10.12.5.

uaparser::parse_agents("Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76B) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.133 Mobile Safari/535.19")

Works fine (in Terminal, but not RStudio because #8)

@Ironholds
Copy link
Contributor

Yeah, I'm REALLY looking forward to having the time to just rewrite all this shit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants