Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id needs to be a string #45

Open
stevenalanstark opened this issue Jun 15, 2017 · 0 comments
Open

id needs to be a string #45

stevenalanstark opened this issue Jun 15, 2017 · 0 comments

Comments

@stevenalanstark
Copy link

stevenalanstark commented Jun 15, 2017 •
edited
Loading

id is currently required to be a string.

Numbers are also very convenient, so it'd be nice to support both.

When changing this to allow for both, there is a fallout issue that if the id is 0, then it fails various truthy tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevenalanstark