Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created request and response objects for sdk 2.x #222

Merged
merged 8 commits into from
Mar 2, 2024
Merged

Created request and response objects for sdk 2.x #222

merged 8 commits into from
Mar 2, 2024

Conversation

lalwani
Copy link
Collaborator

@lalwani lalwani commented Feb 27, 2024 •
edited
Loading

Added

  • AuthContext: Request config that third party uses to pass relevant config information
  • AuthDestination: Config for how the third party wants to use the SSO flow. InApp will use custom tabs. CrossApp will use first party apps in the order of priority provided
  • AuthResponse: Response to the third party after completing the SSO flow
  • AuthType: Whether it's auth code flow or pkce flow. Note - Implicit flow has been dropped from the old sdk
  • CrossApp: List of available first party apps that could be used for SSO
  • PrefillInfo: Profile information from the partner app to prefill in the Uber SSO flow
  • AuthException: Describes the exception if login was not successful

@lalwani lalwani linked an issue Feb 27, 2024 that may be closed by this pull request
Create API scaffolding for the sdk 2.x #218
Open
@lalwani lalwani requested review from psteiger and tyvsmith February 28, 2024 20:30
@lalwani lalwani changed the title Created API scaffolding for the sdk 2.x Created request and response objects for sdk 2.x Feb 28, 2024
psteiger
psteiger reviewed Mar 1, 2024
View reviewed changes
Copy link

@psteiger psteiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a personal preference of grouping the top-level definitions in a single file if they're small and closely related to each other. But that's just preference.

@lalwani
Copy link
Collaborator Author

lalwani commented Mar 1, 2024

I have a personal preference of grouping the top-level definitions in a single file if they're small and closely related to each other. But that's just preference.

I'd like to keep it this way. To me it becomes easier in searching, referencing and more readable. Thanks for the suggestion.

@lalwani lalwani merged commit 673fa56 into uber:2.x Mar 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteiger psteiger psteiger approved these changes

@tyvsmith tyvsmith Awaiting requested review from tyvsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create API scaffolding for the sdk 2.x
2 participants
@lalwani @psteiger