-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a start message saying the bot is "thinking" is displayed #58
base: development
Are you sure you want to change the base?
fix: a start message saying the bot is "thinking" is displayed #58
Conversation
To me it seems that it would be more important to standardize this across every plugin vs adding this custom capability. This is accruing tech debt. But the feature is nice to have and I suppose the code changes are fine. It just seems that very little of the changes are actually related to the spec. Also I suppose that we should run the precheck when the pull is opened as well, even if it isn't a draft. |
@0x4007 I started at first but it implied a lot of changes that went far beyond the spec. Also, I guess you noticed ubiquity-os/plugin-sdk#63 which will be handy to solve this as well, this is the only plugin so far that also will answer to comments in pull-request and pull-request reviews, which is not handled yet by the SDK |
Resolves #52
QA: Meniole#1 (comment)
I needed to add the capability to edit comments to this plugin. It should be using the SDK later on, but it required too much changes and fell out of scope of this issue.