Add `fee` properties to `result` data structure #57

rndquu · 2024-07-13T15:10:58Z

this looks good but I have another idea:

how about we add another variable fee (percentage) and totalAfterFee/totalBeforeFee and we leave other values unmodified? this way we can display a comment which includes information about the total reward, how much was the fee and total reward after the fee.

This would increase transparency so the user can clearly see how much the comments/task was worth and sees how much was the fee

Originally posted by @whilefoo in #43 (review)

The text was updated successfully, but these errors were encountered:

rndquu · 2024-07-15T12:54:42Z

@whilefoo @gentlementlegen

So this issue implies refactoring the result data structure to be (example):

{
  "userName": {
    "fee": 10, # percentage
    "totalBeforeFee": 1000,
    "totalAfterFee": 900,
    ...other properties

Sounds good?

gentlementlegen · 2024-07-15T13:01:46Z

@rndquu Will you keep the total as well? The sum currently takes all the rewards within the data and puts them inside of total
https://github.com/ubiquibot/conversation-rewards/blob/development/src/parser/processor.ts#L78
so keep this in mind when you name the elements. Otherwise good with the idea.

gentlementlegen · 2024-10-12T05:17:17Z

@rndquu I suppose only fee should be required? If it is just a percentage the before and after should be easy to figure out. And maybe we should rename it feePercentage for clarity?

gentlementlegen · 2024-10-12T05:19:23Z

/start

ubiquity-os · 2024-10-12T05:19:27Z

! You have reached your max task limit. Please close out some tasks before assigning new ones.

ubiquity-os-beta · 2024-10-12T05:19:28Z

! You have reached your max task limit. Please close out some tasks before assigning new ones.

gentlementlegen · 2024-10-12T05:55:49Z

I checked the configuration and the max assigned tasks is 2. I am assigned to three, but opened a PR against two of them, shouldn't I be allowed to start? @0x4007

ubiquity-os-beta · 2024-10-12T05:56:00Z

@gentlementlegen the deadline is at Sat, Oct 12, 6:55 AM UTC

ubiquity-os · 2024-10-12T05:56:00Z

@gentlementlegen the deadline is at Sat, Oct 12, 6:55 AM UTC

0x4007 · 2024-10-12T07:48:44Z

I checked the configuration and the max assigned tasks is 2. I am assigned to three, but opened a PR against two of them, shouldn't I be allowed to start? @0x4007

There's an issue Whilefoo filed that outlines what we are still missing from the original implementation.

Basically after a 24 hour reviewer timeout you get an extra task

After any pull is approved by one reviewer you get an extra task

I think there was another condition but I'm forgetting at the moment.

My start attempts were also being rejected and I did a graphql call to see my five assigned issues.

Three were in the sandbox

One was in an archived repository from four years ago

So basically we need to only search from what tasks are inside of the DevPool directory, as that would have solved this problem. I believe I filed an issue for that as well.

ubiquity-os-beta · 2024-10-16T05:10:10Z

[ 50 WXDAI ]
@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	50
Issue	Comment	3	0
Review	Comment	7	0

Conversation Incentives

Comment	Formatting	Relevance
@rndquu Will you keep the `total` as well? The sum curre…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 49 wordValue: 0 result: 0	0.85
@rndquu I suppose only `fee` should be required? If it i…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0 result: 0	0.8
I checked the configuration and the max assigned tasks is 2. I a…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 32 wordValue: 0 result: 0	0.3
Resolves #57 QA: https://github.com/Meniole/conversation-rewar…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 13 wordValue: 0 result: 0	0.7
It is in the linked QA:<img width="508" alt="image" src="ht…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 35 wordValue: 0 result: 0	0.5
It's to avoid a name clash with the one that is sent to the perm…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0 result: 0	0.4
These are workflow inputs not environment variables, they should…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0 result: 0	0.8
At some point cspell wouldn't want to pickup its configuration, …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0 result: 0	0.3
@0x4007 Let me know if you are okay with the display and I will …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0 result: 0	0.2
New QA: https://github.com/Meniole/conversation-rewards/issues/2…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 21 wordValue: 0 result: 0	0.6

[ 19.131 WXDAI ]
@rndquu

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	13.23
Issue	Comment	1	5.901

Conversation Incentives

Comment

Formatting

Relevance

Reward

this looks good but I have another idea: how about we add anot…

4.41

content:
  content:
    p:
      score: 0
      elementCount: 4
    em:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 86
  wordValue: 0.1
  result: 4.41

1

13.23

@whilefoo @gentlementlegen So this issue implies refactoring t…

6.06

content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 16
  wordValue: 0.1
  result: 1.06

0.85

5.901

[ 16.616 WXDAI ]
@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	5.151
Review	Comment	9	11.465

Conversation Incentives

Comment	Formatting	Relevance	Reward
There's an issue Whilefoo filed that outlines what we are still …	6.93 content: content: h2: score: 1 elementCount: 1 p: score: 0 elementCount: 1 result: 1 regex: wordCount: 122 wordValue: 0.1 result: 5.93	0.7	5.151
Cspell changes don't make sense to me	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0.1	0.059
```suggestionAPP_ID: ${{ secrets.APP_ID …	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.8	0.312
This is interesting. Unsure if this is the most presentable way.…	8.4 content: content: p: score: 0 elementCount: 2 h6: score: 1 elementCount: 1 a: score: 5 elementCount: 1 result: 6 regex: wordCount: 42 wordValue: 0.1 result: 2.4	0.6	7.44
```suggestionimport logger from "../helpers/logger…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.5	0.47
I think it makes sense to keep the references to the same values…	1.33 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33	0.7	0.931
Why did you change this logic?	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.2	0.092
Renaming doesn't seem right	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.3	0.117
Thanks for the QAAs part of a separate task, I think we should …	1.8 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 30 wordValue: 0.1 result: 1.8	0.9	1.62
Just noticed the committed compiled js. I'm assuming this is nec…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.4	0.424

ubiquity-os · 2024-10-16T05:10:11Z

[ 50 WXDAI ]
@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	50
Issue	Comment	3	0
Review	Comment	7	0

Conversation Incentives

Comment	Formatting	Relevance
@rndquu Will you keep the `total` as well? The sum curre…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 49 wordValue: 0 result: 0	0.85
@rndquu I suppose only `fee` should be required? If it i…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0 result: 0	0.9
I checked the configuration and the max assigned tasks is 2. I a…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 32 wordValue: 0 result: 0	0.4
Resolves #57 QA: https://github.com/Meniole/conversation-rewar…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 13 wordValue: 0 result: 0	0.5
It is in the linked QA:<img width="508" alt="image" src="ht…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 35 wordValue: 0 result: 0	0.7
It's to avoid a name clash with the one that is sent to the perm…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0 result: 0	0.6
These are workflow inputs not environment variables, they should…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0 result: 0	0.8
At some point cspell wouldn't want to pickup its configuration, …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0 result: 0	0.4
@0x4007 Let me know if you are okay with the display and I will …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0 result: 0	0.4
New QA: https://github.com/Meniole/conversation-rewards/issues/2…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 21 wordValue: 0 result: 0	0.6

[ 19.184 WXDAI ]
@rndquu

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	13.23
Issue	Comment	1	5.954

Conversation Incentives

Comment

Formatting

Relevance

Reward

this looks good but I have another idea: how about we add anot…

4.41

content:
  content:
    p:
      score: 0
      elementCount: 4
    em:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 86
  wordValue: 0.1
  result: 4.41

1

13.23

@whilefoo @gentlementlegen So this issue implies refactoring t…

6.06

content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 16
  wordValue: 0.1
  result: 1.06

0.9

5.954

[ 14.859 WXDAI ]
@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	4.558
Review	Comment	9	10.301

Conversation Incentives

Comment	Formatting	Relevance	Reward
There's an issue Whilefoo filed that outlines what we are still …	6.93 content: content: h2: score: 1 elementCount: 1 p: score: 0 elementCount: 1 result: 1 regex: wordCount: 122 wordValue: 0.1 result: 5.93	0.6	4.558
Cspell changes don't make sense to me	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0.1	0.059
```suggestionAPP_ID: ${{ secrets.APP_ID …	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.7	0.273
This is interesting. Unsure if this is the most presentable way.…	8.4 content: content: p: score: 0 elementCount: 2 h6: score: 1 elementCount: 1 a: score: 5 elementCount: 1 result: 6 regex: wordCount: 42 wordValue: 0.1 result: 2.4	0.5	7.2
```suggestionimport logger from "../helpers/logger…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.6	0.564
I think it makes sense to keep the references to the same values…	1.33 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33	0.8	1.064
Why did you change this logic?	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.2	0.092
Renaming doesn't seem right	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.3	0.117
Thanks for the QAAs part of a separate task, I think we should …	1.8 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 30 wordValue: 0.1 result: 1.8	0.4	0.72
Just noticed the committed compiled js. I'm assuming this is nec…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.2	0.212

ubiquity-os-beta · 2024-10-23T06:07:58Z

[ 50 WXDAI ]
@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	50
Issue	Comment	3	0
Review	Comment	8	0

Conversation Incentives

Comment	Formatting	Relevance
@rndquu Will you keep the `total` as well? The sum curre…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 49 wordValue: 0 result: 0	0.85
@rndquu I suppose only `fee` should be required? If it i…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 31 wordValue: 0 result: 0	0.9
I checked the configuration and the max assigned tasks is 2. I a…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 32 wordValue: 0 result: 0	0.4
Resolves #57 QA: https://github.com/Meniole/conversation-rewar…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 13 wordValue: 0 result: 0	0.6
It is in the linked QA:<img width="508" alt="image" src="ht…	0 content: content: p: score: 0 elementCount: 3 result: 0 regex: wordCount: 35 wordValue: 0 result: 0	0.4
It's to avoid a name clash with the one that is sent to the perm…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0 result: 0	0.5
These are workflow inputs not environment variables, they should…	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 17 wordValue: 0 result: 0	0.8
At some point cspell wouldn't want to pickup its configuration, …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 27 wordValue: 0 result: 0	0.3
@0x4007 Let me know if you are okay with the display and I will …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 18 wordValue: 0 result: 0	0.2
New QA: https://github.com/Meniole/conversation-rewards/issues/2…	0 content: content: p: score: 0 elementCount: 2 result: 0 regex: wordCount: 21 wordValue: 0 result: 0	0.5
@0x4007 Yes otherwise we should have to compile it. I'll have a …	0 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 22 wordValue: 0 result: 0	0.4

[ 19.131 WXDAI ]
@rndquu

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	13.23
Issue	Comment	1	5.901

Conversation Incentives

Comment

Formatting

Relevance

Reward

this looks good but I have another idea: how about we add anot…

4.41

content:
  content:
    p:
      score: 0
      elementCount: 4
    em:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 86
  wordValue: 0.1
  result: 4.41

1

13.23

@whilefoo @gentlementlegen So this issue implies refactoring t…

6.06

content:
  content:
    p:
      score: 0
      elementCount: 3
    a:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 16
  wordValue: 0.1
  result: 1.06

0.85

5.901

[ 15.438 WXDAI ]
@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	4.558
Review	Comment	9	10.88

Conversation Incentives

Comment	Formatting	Relevance	Reward
There's an issue Whilefoo filed that outlines what we are still …	6.93 content: content: h2: score: 1 elementCount: 1 p: score: 0 elementCount: 1 result: 1 regex: wordCount: 122 wordValue: 0.1 result: 5.93	0.6	4.558
Cspell changes don't make sense to me	0.59 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 8 wordValue: 0.1 result: 0.59	0.1	0.059
```suggestionAPP_ID: ${{ secrets.APP_ID …	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.8	0.312
This is interesting. Unsure if this is the most presentable way.…	8.4 content: content: p: score: 0 elementCount: 2 h6: score: 1 elementCount: 1 a: score: 5 elementCount: 1 result: 6 regex: wordCount: 42 wordValue: 0.1 result: 2.4	0.5	7.2
```suggestionimport logger from "../helpers/logger…	0.94 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 14 wordValue: 0.1 result: 0.94	0.7	0.658
I think it makes sense to keep the references to the same values…	1.33 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 21 wordValue: 0.1 result: 1.33	0.7	0.931
Why did you change this logic?	0.46 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 6 wordValue: 0.1 result: 0.46	0.3	0.138
Renaming doesn't seem right	0.39 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 5 wordValue: 0.1 result: 0.39	0.2	0.078
Thanks for the QAAs part of a separate task, I think we should …	1.8 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 30 wordValue: 0.1 result: 1.8	0.6	1.08
Just noticed the committed compiled js. I'm assuming this is nec…	1.06 content: content: p: score: 0 elementCount: 1 result: 0 regex: wordCount: 16 wordValue: 0.1 result: 1.06	0.4	0.424

0x4007 added the Priority: 2 (Medium) label Jul 13, 2024

gentlementlegen added the Time: <1 Hour label Oct 12, 2024

ubiquity-os-beta bot added the Price: 50 USD label Oct 12, 2024

gentlementlegen self-assigned this Oct 12, 2024

gentlementlegen mentioned this issue Oct 13, 2024

feat: fee value #159

Merged

0x4007 closed this as completed in #159 Oct 16, 2024

gentlementlegen reopened this Oct 23, 2024

gentlementlegen closed this as completed Oct 23, 2024

Add fee properties to result data structure #57

Add fee properties to result data structure #57

Comments

rndquu commented Jul 13, 2024

rndquu commented Jul 15, 2024

gentlementlegen commented Jul 15, 2024

gentlementlegen commented Oct 12, 2024

gentlementlegen commented Oct 12, 2024

ubiquity-os bot commented Oct 12, 2024

ubiquity-os-beta bot commented Oct 12, 2024

gentlementlegen commented Oct 12, 2024

ubiquity-os-beta bot commented Oct 12, 2024

ubiquity-os bot commented Oct 12, 2024

0x4007 commented Oct 12, 2024 • edited Loading

ubiquity-os-beta bot commented Oct 16, 2024 • edited Loading

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

ubiquity-os bot commented Oct 16, 2024 • edited Loading

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

ubiquity-os-beta bot commented Oct 23, 2024 • edited Loading

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Contributions Overview

Conversation Incentives

Add `fee` properties to `result` data structure #57

Add `fee` properties to `result` data structure #57

0x4007 commented Oct 12, 2024 •

edited

Loading

ubiquity-os-beta bot commented Oct 16, 2024 •

edited

Loading

ubiquity-os bot commented Oct 16, 2024 •

edited

Loading

ubiquity-os-beta bot commented Oct 23, 2024 •

edited

Loading