Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @ubiquity-dao/rpc-handler instead of hardcoded RPC urls #18

Closed
rndquu opened this issue Jun 14, 2024 · 2 comments · Fixed by #19
Closed

Use @ubiquity-dao/rpc-handler instead of hardcoded RPC urls #18

rndquu opened this issue Jun 14, 2024 · 2 comments · Fixed by #19

Comments

@rndquu
Copy link
Member

rndquu commented Jun 14, 2024

Right now RPC urls used for reading onchain data are hardcoded in this file.

What should be done:

Copy link

ubiquibot bot commented Jul 6, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Jul 6, 2024

[ 2.7 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
ReviewComment12.7
Conversation Incentives
CommentFormattingRelevanceReward
@rndquu Wrote the spec and approved the pull so I think it's an ...
2.70.352.7

[ 21.7 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
ReviewComment421.7
Conversation Incentives
CommentFormattingRelevanceReward
Tests seem to works but some of them do not exit properly, I sus...
3.5
a:
  count: 1
  score: "1"
  words: 1
0.323.5
@Keyrxng A common scenario I encountered is when you import a fi...
7.4
code:
  count: 2
  score: "2"
  words: 3
0.57.4
@Keyrxng Could you then try to: - hard code these calls and see...
4.8
li:
  count: 2
  score: "2"
  words: 22
0.534.8
I think this should be solved, because at the moment you just ge...
6
code:
  count: 1
  score: "1"
  words: 2
0.576

[ 179.6 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask150
ReviewComment564.8
ReviewComment564.8
Conversation Incentives
CommentFormattingRelevanceReward
> Tests seem to works but some of them do not exit properly, ...
12
a:
  count: 2
  score: "2"
  words: 3
code:
  count: 3
  score: "3"
  words: 4
0.6612
@gentlementlegen I understand what you mean and why that would b...
20.8
code:
  count: 3
  score: "3"
  words: 5
0.5220.8
> @Keyrxng A common scenario I encountered is when you import...
14.9
code:
  count: 8
  score: "8"
  words: 9
0.5514.9
@gentlementlegen I've mocked the handler and return a valid prov...
11.3
code:
  count: 1
  score: "1"
  words: 2
0.8511.3
Resolved in `rpc-handler` and I've linked the updated pa...
5.8
code:
  count: 2
  score: "2"
  words: 3
0.635.8
> Tests seem to works but some of them do not exit properly, ...
12
a:
  count: 2
  score: "2"
  words: 3
code:
  count: 3
  score: "3"
  words: 4
0.6612
@gentlementlegen I understand what you mean and why that would b...
20.8
code:
  count: 3
  score: "3"
  words: 5
0.5220.8
> @Keyrxng A common scenario I encountered is when you import...
14.9
code:
  count: 8
  score: "8"
  words: 9
0.5514.9
@gentlementlegen I've mocked the handler and return a valid prov...
11.3
code:
  count: 1
  score: "1"
  words: 2
0.8511.3
Resolved in `rpc-handler` and I've linked the updated pa...
5.8
code:
  count: 2
  score: "2"
  words: 3
0.635.8

[ 11.8 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification111.8
Conversation Incentives
CommentFormattingRelevanceReward
Right now RPC urls used for reading onchain data are hardcoded i...
11.8
a:
  count: 1
  score: "1"
  words: 1
li:
  count: 2
  score: "2"
  words: 26
111.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants