Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Improve testing for users/builders #60

Open
vt-alt opened this issue Oct 27, 2023 · 1 comment
Open

FR: Improve testing for users/builders #60

vt-alt opened this issue Oct 27, 2023 · 1 comment

Comments

@vt-alt
Copy link

vt-alt commented Oct 27, 2023

Currently tests always return success even on failures. For example if fio is not installed, exit code of all tests run is 0.

Also, it's hard to determine if some particular tests are failed, for example generic/001 output is not different if fio is installed or not, but perhaps it didn't work correctly without fio.

It would be good to have

  1. Tests return failure if they fail
  2. Define small subset tests that not taking much time for smoke testing after build.
@ming1
Copy link
Collaborator

ming1 commented Oct 28, 2023

fio is heavy relied, so it has to be one must for test.

Wrt. smoking test, I think it is just fine to run the following test:

make test T=generic/003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants