Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make summary check suitable for blocking PRs #17

Closed
nwiltsie opened this issue Mar 5, 2024 · 0 comments · Fixed by #25
Closed

Make summary check suitable for blocking PRs #17

nwiltsie opened this issue Mar 5, 2024 · 0 comments · Fixed by #25

Comments

@nwiltsie
Copy link
Member

nwiltsie commented Mar 5, 2024

It may be worth making the regression test(s) a required passing check before merging PRs similar to how we have CI/CD set

Yeah, we'll need to work out the best way of doing that - the job names are somewhat dynamic, as they match the test files on disk, so tracking all of them is a moving target. Maybe we can add a summary "all tests passed" check to the Action and then depend upon that.

Originally posted by @nwiltsie in uclahs-cds/pipeline-recalibrate-BAM#55 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant