Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete async flags in application manifest #179

Open
wridgeu opened this issue May 4, 2022 · 0 comments
Open

Remove obsolete async flags in application manifest #179

wridgeu opened this issue May 4, 2022 · 0 comments
Assignees
@petermuessig

Comments

@wridgeu
Copy link
Contributor

wridgeu commented May 4, 2022

Hey 👋

I think this can be removed

bestofui5-website/src/manifest.json

Line 44 in d358a50

"async": true,

according to sap.ui.core.IAsyncContentCreation

bestofui5-website/src/Component.ts

Lines 22 to 24 in d358a50

// marker to identify async content creation
// makes async: true for rootView obsolete!
interfaces: ["sap.ui.core.IAsyncContentCreation"],

probably this one as well (based on the documentation)

bestofui5-website/src/manifest.json

Line 104 in d358a50

"async": true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermuessig petermuessig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petermuessig @wridgeu