Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show users that a resource is pre-release in updates dialog & SP #7391

Closed
3 of 4 tasks
PhotoNomad0 opened this issue Aug 14, 2022 · 8 comments
Closed
3 of 4 tasks

Show users that a resource is pre-release in updates dialog & SP #7391

PhotoNomad0 opened this issue Aug 14, 2022 · 8 comments
Assignees

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Aug 14, 2022

Issue:

Currently, once a user chooses to see pre-releases in the update dialog, those resources appear like any other resources, both in the update dialog and in the Scripture Pane. Users need some indicator that they are working with a pre-release.

DoD:

Update Identifiers to read like: [English - Door43] - Pre-release

Details:

  • Updates Dialog
  • Scripture pane add resources
  • Scripture pane title (hover text)
  • Expanded Scripture pane (hover text)
@PhotoNomad0
Copy link
Contributor Author

@elsylambert This is only part of the Epic. Fix is in translationCore 3.3.0 (421972d). There is a separate issue for GL drop down on tools: #7378

@PhotoNomad0
Copy link
Contributor Author

@birchamp ^^^

@elsylambert
Copy link

Screen Shot 2022-08-15 at 9 00 13 AM

@elsylambert
Copy link

Looks good in translationCore 3.3.0 (df4a8a6). The Pre-released resources shows in [] and Pre-Release title, in 1. Content Update dialogue
Screen Shot 2022-08-16 at 8 46 55 AM

  1. Scripture Pane Add Resource

Screen Shot 2022-08-16 at 8 53 24 AM

  1. Scripture Pane hover text.

Screen Shot 2022-08-16 at 8 53 58 AM

@elsylambert
Copy link

Wrote up #7404 for the Expanded Scripture Pane part of this issue.

@elsylambert
Copy link

Something got messed up in translationCore 3.3.0 (fb96f72). Pre-Release title shows "Missing translation key" for Scripture Pane and Add scripture Resource drop down.
Screen Shot 2022-08-18 at 10 31 25 AM
Screen Shot 2022-08-18 at 10 36 07 AM

@PhotoNomad0
Copy link
Contributor Author

@elsylambert found a typo, the locale key should have been pre_release, not pre-release. Fix is in translationCore 3.3.0 (ce8ec7b)

@elsylambert
Copy link

Looks good in translationCore 3.3.0 (ce8ec7b).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants