Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bincode 2 derives instead of bincode 1 via serde #3420

Open
benluelo opened this issue Dec 31, 2024 · 0 comments
Open

Use bincode 2 derives instead of bincode 1 via serde #3420

benluelo opened this issue Dec 31, 2024 · 0 comments
Labels
C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-tedious Call for participation: An issue involves lots of work and is better handled as many small tasks.

Comments

@benluelo
Copy link
Contributor

https://docs.rs/bincode/2.0.0-rc.3/bincode/serde/index.html#known-issues
serde-rs/serde#2045

#[derive(bincode::Encode, bincode::Decode)] instead of de/serializing bincode via serde.

  • add [email protected] to the workspace Cargo.toml
  • feature gate bincode on all crates that use it
  • add unit tests for types to ensure they round trip properly
@benluelo benluelo added E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-tedious Call for participation: An issue involves lots of work and is better handled as many small tasks. C-bug Category: This is a bug. labels Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-tedious Call for participation: An issue involves lots of work and is better handled as many small tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benluelo