Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about calculating angles and 'eta_fit_grass.npy' #2

Open
hanin97 opened this issue Apr 12, 2024 · 2 comments
Open

questions about calculating angles and 'eta_fit_grass.npy' #2

hanin97 opened this issue Apr 12, 2024 · 2 comments

Comments

@hanin97
Copy link

hanin97 commented Apr 12, 2024

Hi, thank you for your interesting work, I have some questions.

  1. Since angels can be calculated as Intensity(R,rho,alpha)/maxIntensity(r,rho,alpha) at every range given points and labels, why we need an alpha_predictor to predict angels?
  2. We can see 'p = np.poly1d(fit)' at line 99 in file 'data_generator.py', but parameter 'p' seems not being used in following code, the same as in 'data_generator_sem_poss.py' and 'data_generator_kitti.py'
@kasiv008
Copy link
Collaborator

Thank you for the question.
1#
Using the equation, angles can be computed only when the classes/labels are known. If we are given a point cloud to segment, we would need the alpha predictor to predict the angles as there is not labels/class given.

2#
The polyfit is to remove near-range effect. apparently the LiDAR used in Semantic Kitti (HDL-64E) has already been calibrated for near-range effect. the same goes with Pandora LiDAR used in SemanticPOSS. Hence the fitting function has been commented.

@Deanoh90 Deanoh90 mentioned this issue Apr 11, 2024
@hanin97
Copy link
Author

hanin97 commented Apr 15, 2024

Thank you for your reply, but I still have some questions about question1,

  1. I have checked the inference code which can be found at ·‘tasks/semantic/modules/user2.py’, we can see that the function infer_subset doesn't need the parameter near_range returned by the dataset and the parameter proj doesn't contain proj_reflectivity nor proj_near_range while reflectivity_flag=False' and near_range_flag=False` in salsanextearly_rxyzi2.yaml. Does it mean that while inferring a point cloud, there's no need to get the angles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants