Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Accessor of oidc auth backend in groupAlias #36

Open
kamalverma1 opened this issue Apr 13, 2024 · 2 comments
Open

Reference Accessor of oidc auth backend in groupAlias #36

kamalverma1 opened this issue Apr 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@kamalverma1
Copy link

What problem are you facing?

There should be a way to reference the accessor for the oidc method and also the canonicalId of groups while creating a group Alias. This is an issue if the Resource is created by a seperate claim.

How could Upbound help solve your problem?

Add somthing similar to Data Source in in terraform. Maybe somthing similar to referencing VPCID in this doc.

For example:

apiVersion: identity.vault.upbound.io/v1alpha1
kind: GroupAlias
metadata:
  annotations:
    meta.upbound.io/example-id: identity/v1alpha1/groupalias
  labels:
    testing.upbound.io/example-name: group-alias
  name: cld-csm-admins-sg-kdtesting
spec:
  deletionPolicy: Delete
  forProvider:
    namespace: mytestns
    canonicalIdRef: 
      name: <mytestgroup>
    mountAccessorRef: 
      name: <oidc-auth-backend-name> 
    name: <group-ObjectId>
    ----
@kamalverma1 kamalverma1 added the enhancement New feature or request label Apr 13, 2024
@tschlaepfer
Copy link

Agree, would very much like this :)

@tschlaepfer tschlaepfer mentioned this issue May 27, 2024
2 tasks
@tschlaepfer
Copy link

I have created a draft MR for this feature, however, I'm not used to Go nor creating Crossplane providers so I would need some support. Right now I'm still struggling with the code to create a reference for different AuthBackend types.

# config.go
....
r.References["mount_accessor"] = config.Reference{
    Type: "github.com/upbound/provider-vault/apis/jwt/v1alpha1.AuthBackend",
    Extractor: common.AccessorExtractor,
}

Do to the way the Terraform code for HashiCorp Vault has been written one would need to be able to configure multiple types here.

Could someone from the maintainers guide me on how this should be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants