Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Types with library #57

Open
3 tasks
rushildev opened this issue May 11, 2023 · 1 comment
Open
3 tasks

Package Types with library #57

rushildev opened this issue May 11, 2023 · 1 comment

Comments

@rushildev
Copy link

rushildev commented May 11, 2023

All bugs, feature requests, implementation concerns or general queries should be sent to our support team.

You are welcome to submit an issue here for bugs, but please also reach out to our support team as well.

Before completing the form below, please check the following:

  • You are using the most recent version of the library.
  • You are using a supported version of Python for that library version.
  • This issue is reproducible.

Expected Behavior

The library should be packaged with type annotations.

Current Behavior

The library does not included type annotations

Possible Solution

Support PEP 561 -- include types in published package

Steps to Reproduce

  1. Install urbanairship in a python project
  2. Import any class from the urbanairship package
  3. Run a type linter like mypy
  4. Observe that linter will report urbanairship is missing type annotations.

Detailed Description

It appears as if the library source code is typed. Why not also package the types along for consumers that leverage type annotations.

Possible Fix

@pdxmele
Copy link
Member

pdxmele commented May 11, 2023

Thanks, we've made a ticket for this on our side and will get to it when we have the chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants