Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit WordPress plugin markup output #1

Open
logicelf opened this issue Feb 17, 2022 · 0 comments
Open

Edit WordPress plugin markup output #1

logicelf opened this issue Feb 17, 2022 · 0 comments
Assignees

Comments

@logicelf
Copy link
Contributor

Rendered screenshots overflow the default WordPress theme width. After some experimentation, and having reviewed the latest WordPress Codex docs, I suggest the following changes to the markup that the plugin outputs:

  1. Change the wrapping div to a figure element
  2. Hard-code that figure element with the wp-block-image class
  3. Update the plugin settings page text accordingly

This should allow outputted images to be as compatible as possible with modern WordPress coding standards and the majority of themes, while still allowing users to override the outer and inner elements if necessary.

@logicelf logicelf self-assigned this Feb 17, 2022
AJCJ1 pushed a commit that referenced this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant