Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some methods for encoding/decoding are implemented manually #46

Open
ushmz opened this issue Oct 28, 2022 · 0 comments
Open

Some methods for encoding/decoding are implemented manually #46

ushmz opened this issue Oct 28, 2022 · 0 comments
Assignees
Labels
improvement Improve existing feature

Comments

@ushmz
Copy link
Owner

ushmz commented Oct 28, 2022

Is your feature request related to a problem? Please describe.

Some factory methods and extensions are manually implemented, which are used to encode/decode JSON. These can be generate with package and reduce some code.

e.g.

  • fromJson(), toJSON() methods.
  • Getting Enum value from ID, (and verse vice).

It's not a serious problem, priority is relatively low.

Describe the solution you'd like

Use json_serializable package to simplify code.

Describe alternatives you've considered

For now, necessary methods are manually implemented, so "wontfix" is also good.

Additional context

@ushmz ushmz added the improvement Improve existing feature label Oct 28, 2022
@ushmz ushmz self-assigned this Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve existing feature
Projects
None yet
Development

No branches or pull requests

1 participant