-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example is wrong #36
Comments
Thank you! I'll fix this soon! |
Don't forget that you can send PR ❤️ |
Nvm now Vite throws
|
It doesn't work either way |
What version do you use? Can you send me link to reproduce this bug? |
Hello @vaban-ru, your library looks sleek in the demo, but i'm also having difficulty trying to make it work in Vue 3 + composition api setup script. You can refer to the details below. Hope this helps you in reproducing the bug! Added VueBottomSheet on a branch on my project — i didn't pass any props since there's plenty of defaults set already: https://github.com/lyqht/styled-qr-code-generator/blob/dabb28acdfc5fc189c265312aec0ef4b99eb8a9a/src/App.vue#L656-L662 Screenshots in trying to debug EDIT: Here, I just realized i have to manually open the bottomsheet. It will be nice if there's a prop for us to just set if it is So after adding a basic onMounted function to open the bottom sheet, i can see it. But I cannot see its content or modify the width. Setting |
Hello! I will try to reproduce this bug today and get back to you with an answer right away |
Hey! I released new 3.0.5 version, and fix bug with typescript typings, and fix width issue You can't see the content because it is white text color)) just change its color |
Hey there! thank you for getting back so fast. v3.0.5 fixed the TS & width issue for me! There's some feature request issues that i'll raise separately later on, hope you don't feel stressed about those, those are just suggestions! |
The correct import while using TypeScript is
instead of
Please fix package.json to use let typescript detect the types declaration file
Thanks in advance
The text was updated successfully, but these errors were encountered: