Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example is wrong #36

Open
PolpOnline opened this issue Aug 4, 2023 · 10 comments
Open

Example is wrong #36

PolpOnline opened this issue Aug 4, 2023 · 10 comments

Comments

@PolpOnline
Copy link

The correct import while using TypeScript is

import VueBottomSheet from "@webzlodimir/vue-bottom-sheet/dist";

instead of

import VueBottomSheet from "@webzlodimir/vue-bottom-sheet";

Please fix package.json to use let typescript detect the types declaration file

Thanks in advance

@vaban-ru
Copy link
Owner

vaban-ru commented Aug 4, 2023

The correct import while using TypeScript is

import VueBottomSheet from "@webzlodimir/vue-bottom-sheet/dist";

instead of

import VueBottomSheet from "@webzlodimir/vue-bottom-sheet";

Please fix package.json to use let typescript detect the types declaration file

Thanks in advance

Thank you! I'll fix this soon!

@vaban-ru
Copy link
Owner

vaban-ru commented Aug 4, 2023

The correct import while using TypeScript is

import VueBottomSheet from "@webzlodimir/vue-bottom-sheet/dist";

instead of

import VueBottomSheet from "@webzlodimir/vue-bottom-sheet";

Please fix package.json to use let typescript detect the types declaration file

Thanks in advance

Don't forget that you can send PR ❤️

@PolpOnline
Copy link
Author

PolpOnline commented Aug 4, 2023

Nvm now Vite throws

Error: Missing "./dist" specifier in "@webzlodimir/vue-bottom-sheet" package

@PolpOnline
Copy link
Author

It doesn't work either way

@vaban-ru
Copy link
Owner

vaban-ru commented Aug 4, 2023

It doesn't work either way

image
I tried to specify the dist folder and then it does not work, but it works fine if you do not specify the dist folder
image

@vaban-ru
Copy link
Owner

vaban-ru commented Aug 4, 2023

What version do you use? Can you send me link to reproduce this bug?

@lyqht
Copy link

lyqht commented Aug 11, 2023

Hello @vaban-ru, your library looks sleek in the demo, but i'm also having difficulty trying to make it work in Vue 3 + composition api setup script.

You can refer to the details below. Hope this helps you in reproducing the bug!

Added VueBottomSheet on a branch on my project — i didn't pass any props since there's plenty of defaults set already: https://github.com/lyqht/styled-qr-code-generator/blob/dabb28acdfc5fc189c265312aec0ef4b99eb8a9a/src/App.vue#L656-L662

Typescript issue
CleanShot 2023-08-10 at 23 00 26

Screenshots in trying to debug
CleanShot 2023-08-10 at 23 10 16

EDIT: Here, I just realized i have to manually open the bottomsheet. It will be nice if there's a prop for us to just set if it is visible or not like how native bottom sheets usually implement that prop.

So after adding a basic onMounted function to open the bottom sheet, i can see it. But I cannot see its content or modify the width. Setting max-width=1000 doesn't help.

https://github.com/lyqht/styled-qr-code-generator/blob/7ed046b60018710f385d4bef65d966ca18e0568c/src/App.vue#L660-L664

CleanShot 2023-08-10 at 23 21 41

@vaban-ru
Copy link
Owner

Hello @vaban-ru, your library looks sleek in the demo, but i'm also having difficulty trying to make it work in Vue 3 + composition api setup script.

You can refer to the details below. Hope this helps you in reproducing the bug!

Hello! I will try to reproduce this bug today and get back to you with an answer right away

@vaban-ru
Copy link
Owner

Hello @vaban-ru, your library looks sleek in the demo, but i'm also having difficulty trying to make it work in Vue 3 + composition api setup script.

You can refer to the details below. Hope this helps you in reproducing the bug!

Hey! I released new 3.0.5 version, and fix bug with typescript typings, and fix width issue
image

You can't see the content because it is white text color)) just change its color

image

@lyqht
Copy link

lyqht commented Aug 12, 2023

Hey there! thank you for getting back so fast. v3.0.5 fixed the TS & width issue for me!

There's some feature request issues that i'll raise separately later on, hope you don't feel stressed about those, those are just suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants