Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of timeouts #173

Open
Grimoren opened this issue Jun 15, 2022 · 6 comments
Open

Allow customization of timeouts #173

Grimoren opened this issue Jun 15, 2022 · 6 comments

Comments

@Grimoren
Copy link

Error occurring during run: Command took too long to execute, try setting a higher timout: '[/bin/sh, -c, dot -Kdot -Tsvg /tmp/GraphvizJava/DotEngine7925473131433663348/dotfile.dot -ooutfile.svg]'

The plugin should have an overridable default timeout.

@vanniktech
Copy link
Owner

We might have to tell the timeout to the underlying graphviz library we're using

@SimonMarquis
Copy link
Contributor

Did you try to configure the Graphviz instance directly with a custom engine with the proper timeout?

Graphviz.useEngine(GraphvizCmdLineEngine().timeout(2, TimeUnit.MINUTES))

@vanniktech
Copy link
Owner

@SimonMarquis what do you think if we provide a reasonable default lets say 30 seconds for the tasks that we create? And any one who needs more can use #183

@SimonMarquis
Copy link
Contributor

The issue with this approach is that it will force everyone to use this engine.
And the Graphviz wrapper we use does rely on a default list of available engines.

https://github.com/nidi3/graphviz-java/blob/f0c1fdfa37c8b9876ef1dcccec1a6c19219e727e/graphviz-java/src/main/java/guru/nidi/graphviz/engine/Graphviz.java#L88

@vanniktech
Copy link
Owner

Aaah I thought GraphvizEngine has a timeout as well :(

@Grimoren
Copy link
Author

How do I access graphViz?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants