Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback URL registered incorrectly if using route groups #43

Open
0xTim opened this issue Dec 11, 2019 · 1 comment · Fixed by #114
Open

Callback URL registered incorrectly if using route groups #43

0xTim opened this issue Dec 11, 2019 · 1 comment · Fixed by #114

Comments

@0xTim
Copy link
Member

0xTim commented Dec 11, 2019

When registering callback URLs with Imperial using router.oAuth, if the router is registered on a route group (e.g. /api) then it registers the callback url on the application incorrectly (such as under /api/api)

@fpseverino
Copy link
Member

This issue isn't really solved for most services (10 out of 13), because those services need in the callback body a redirect_uri. We get it from the callback argument of RoutesBuilder.oAuth, so it needs to be a full URL (e.g. http://localhost:8080/api/oauth/service), but we also use callback to create the route with the RoutesBuilder, so if the latter is grouped let's say on "api", the resulting route is going to be /api/api/oauth/service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants