Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low/Mid/High ranges for BeatDetektor #860

Open
2xAA opened this issue Jun 11, 2023 · 0 comments
Open

Low/Mid/High ranges for BeatDetektor #860

2xAA opened this issue Jun 11, 2023 · 0 comments
Labels
enhancement Feature requests

Comments

@2xAA
Copy link
Member

2xAA commented Jun 11, 2023

BeatDetektor works best when limited to a BPM range.
Currently we have it set to detect between 85 and 169 BPM, which doesn't allow detection of faster music.
https://github.com/vcync/modV/blob/next/src/application/setup-beat-detektor.js#LL4C41-L4C48

A solution to this would be to spawn three instances of Beat Detektor, low BPM, medium BPM and high BPM, then have an instance selectable through the BPM configuration.

The BeatDetektor instance does nothing when it isn't called, so CPU won't be affected, only a small amount of memory.

@2xAA 2xAA added the enhancement Feature requests label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests
Projects
None yet
Development

No branches or pull requests

1 participant