Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Remote Write test suite not passing #7342

Open
RichiH opened this issue May 5, 2021 · 4 comments
Open

Prometheus Remote Write test suite not passing #7342

RichiH opened this issue May 5, 2021 · 4 comments
Assignees
Labels
sink: prometheus_remote_write Anything `prometheus_remote_write` sink related type: bug A code related bug.

Comments

@RichiH
Copy link

RichiH commented May 5, 2021

Vector Version

0.13.1

Vector Configuration File

default configuration

Expected Behavior

Prometheus Remote Write test suite passing

Actual Behavior

We (Prometheus-team) just added test coverage for vector in our Remote Write compliance test. 6/18 tests are passing, the rest failing. NB: We are not certain if there's a mistake in our tests, but we couldn't see anything obviously wrong.

Please see

@RichiH RichiH added the type: bug A code related bug. label May 5, 2021
@jszwedko jszwedko added the sink: prometheus_remote_write Anything `prometheus_remote_write` sink related label May 5, 2021
@jszwedko
Copy link
Member

jszwedko commented May 5, 2021

Nice, thanks @RichiH ! We'll take a look at these.

I am curious to see if it'd be possible to integrate running them into our CI too.

@jszwedko jszwedko added this to the Vector 0.14 milestone May 5, 2021
@RichiH
Copy link
Author

RichiH commented May 5, 2021

And thank you :)

See https://github.com/prometheus/compliance/tree/main/remote_write#running-the-test for how to run the tests just for Vector as part of your CI.

@spencergilbert
Copy link
Contributor

I started looking at this tonight - I've identified one immediate issue with the configuration provided in the compliance test suite. I'm thinking a number of the other test failures are more about the "schema" of the events we send across.

@spencergilbert
Copy link
Contributor

Related: prometheus/compliance#34

@spencergilbert spencergilbert removed their assignment Apr 1, 2022
@StephenWakely StephenWakely self-assigned this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sink: prometheus_remote_write Anything `prometheus_remote_write` sink related type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

4 participants