From 1de6268da997d087f5d7dfdf056ee37fdda91a9a Mon Sep 17 00:00:00 2001 From: tknickman Date: Thu, 18 Jan 2024 10:53:40 -0500 Subject: [PATCH 1/3] fix(build): add peer and optional deps --- packages/web/package.json | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/web/package.json b/packages/web/package.json index e4a70e6..b9dc0ac 100644 --- a/packages/web/package.json +++ b/packages/web/package.json @@ -84,5 +84,11 @@ "react": "^18.2.0", "react-dom": "^18.2.0", "tsup": "7.1.0" + }, + "peerDependencies": { + "react": "^18" + }, + "optionalDependencies": { + "react": "^18" } } From b721c1d08b838392db298436a96acf143e5ba897 Mon Sep 17 00:00:00 2001 From: tknickman Date: Thu, 18 Jan 2024 10:58:29 -0500 Subject: [PATCH 2/3] Update lock --- pnpm-lock.yaml | 132 ++----------------------------------------------- 1 file changed, 5 insertions(+), 127 deletions(-) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index d3ecfb4..bfdc3ae 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -137,6 +137,10 @@ importers: server-only: specifier: ^0.0.1 version: 0.0.1 + optionalDependencies: + react: + specifier: ^18 + version: 18.2.0 devDependencies: '@swc/core': specifier: ^1.3.66 @@ -171,9 +175,6 @@ importers: jest-environment-jsdom: specifier: ^29.5.0 version: 29.5.0 - react: - specifier: ^18.2.0 - version: 18.2.0 react-dom: specifier: ^18.2.0 version: 18.2.0(react@18.2.0) @@ -3104,13 +3105,6 @@ packages: parse5: 7.1.2 dev: true - /@types/json-schema@7.0.11: - resolution: - { - integrity: sha512-wOuvG1SN4Us4rez+tylwwwCV1psiNVOkJeM3AUWUNWg/jDQY2+HE/444y5gc+jBmRqASOm2Oeh5c1axHobwRKQ==, - } - dev: true - /@types/json-schema@7.0.13: resolution: { @@ -3210,13 +3204,6 @@ packages: } dev: true - /@types/semver@7.3.12: - resolution: - { - integrity: sha512-WwA1MW0++RfXmCr12xeYOOC5baSC9mSb0ZqCquFzKhcoF4TvHu5MKOuXsncgZcpVFhB1pXd5hZmM0ryAoCp12A==, - } - dev: true - /@types/semver@7.5.3: resolution: { @@ -3445,17 +3432,6 @@ packages: - supports-color dev: true - /@typescript-eslint/scope-manager@5.40.1: - resolution: - { - integrity: sha512-jkn4xsJiUQucI16OLCXrLRXDZ3afKhOIqXs4R3O+M00hdQLKR58WuyXPZZjhKLFCEP2g+TXdBRtLQ33UfAdRUg==, - } - engines: { node: ^12.22.0 || ^14.17.0 || >=16.0.0 } - dependencies: - '@typescript-eslint/types': 5.40.1 - '@typescript-eslint/visitor-keys': 5.40.1 - dev: true - /@typescript-eslint/scope-manager@5.62.0: resolution: { @@ -3547,14 +3523,6 @@ packages: - supports-color dev: true - /@typescript-eslint/types@5.40.1: - resolution: - { - integrity: sha512-Icg9kiuVJSwdzSQvtdGspOlWNjVDnF3qVIKXdJ103o36yRprdl3Ge5cABQx+csx960nuMF21v8qvO31v9t3OHw==, - } - engines: { node: ^12.22.0 || ^14.17.0 || >=16.0.0 } - dev: true - /@typescript-eslint/types@5.62.0: resolution: { @@ -3571,30 +3539,6 @@ packages: engines: { node: ^16.0.0 || >=18.0.0 } dev: true - /@typescript-eslint/typescript-estree@5.40.1(typescript@5.1.3): - resolution: - { - integrity: sha512-5QTP/nW5+60jBcEPfXy/EZL01qrl9GZtbgDZtDPlfW5zj/zjNrdI2B5zMUHmOsfvOr2cWqwVdWjobCiHcedmQA==, - } - engines: { node: ^12.22.0 || ^14.17.0 || >=16.0.0 } - peerDependencies: - typescript: '*' - peerDependenciesMeta: - typescript: - optional: true - dependencies: - '@typescript-eslint/types': 5.40.1 - '@typescript-eslint/visitor-keys': 5.40.1 - debug: 4.3.4 - globby: 11.1.0 - is-glob: 4.0.3 - semver: 7.3.8 - tsutils: 3.21.0(typescript@5.1.3) - typescript: 5.1.3 - transitivePeerDependencies: - - supports-color - dev: true - /@typescript-eslint/typescript-estree@5.62.0(typescript@5.1.3): resolution: { @@ -3715,29 +3659,6 @@ packages: - supports-color dev: true - /@typescript-eslint/utils@5.40.1(eslint@8.43.0)(typescript@5.1.3): - resolution: - { - integrity: sha512-a2TAVScoX9fjryNrW6BZRnreDUszxqm9eQ9Esv8n5nXApMW0zeANUYlwh/DED04SC/ifuBvXgZpIK5xeJHQ3aw==, - } - engines: { node: ^12.22.0 || ^14.17.0 || >=16.0.0 } - peerDependencies: - eslint: ^6.0.0 || ^7.0.0 || ^8.0.0 - dependencies: - '@types/json-schema': 7.0.11 - '@types/semver': 7.3.12 - '@typescript-eslint/scope-manager': 5.40.1 - '@typescript-eslint/types': 5.40.1 - '@typescript-eslint/typescript-estree': 5.40.1(typescript@5.1.3) - eslint: 8.43.0 - eslint-scope: 5.1.1 - eslint-utils: 3.0.0(eslint@8.43.0) - semver: 7.3.8 - transitivePeerDependencies: - - supports-color - - typescript - dev: true - /@typescript-eslint/utils@5.62.0(eslint@8.43.0)(typescript@5.1.3): resolution: { @@ -3851,17 +3772,6 @@ packages: - typescript dev: true - /@typescript-eslint/visitor-keys@5.40.1: - resolution: - { - integrity: sha512-A2DGmeZ+FMja0geX5rww+DpvILpwo1OsiQs0M+joPWJYsiEFBLsH0y1oFymPNul6Z5okSmHpP4ivkc2N0Cgfkw==, - } - engines: { node: ^12.22.0 || ^14.17.0 || >=16.0.0 } - dependencies: - '@typescript-eslint/types': 5.40.1 - eslint-visitor-keys: 3.3.0 - dev: true - /@typescript-eslint/visitor-keys@5.62.0: resolution: { @@ -6627,7 +6537,7 @@ packages: optional: true dependencies: '@typescript-eslint/eslint-plugin': 6.7.4(@typescript-eslint/parser@6.7.4)(eslint@8.43.0)(typescript@5.1.3) - '@typescript-eslint/utils': 5.40.1(eslint@8.43.0)(typescript@5.1.3) + '@typescript-eslint/utils': 5.62.0(eslint@8.43.0)(typescript@5.1.3) eslint: 8.43.0 transitivePeerDependencies: - supports-color @@ -6988,19 +6898,6 @@ packages: eslint-visitor-keys: 1.3.0 dev: true - /eslint-utils@3.0.0(eslint@8.43.0): - resolution: - { - integrity: sha512-uuQC43IGctw68pJA1RgbQS8/NP7rch6Cwd4j3ZBtgo4/8Flj4eGE7ZYSZRN3iq5pVUv6GPdW5Z1RFleo84uLDA==, - } - engines: { node: ^10.0.0 || ^12.0.0 || >= 14.0.0 } - peerDependencies: - eslint: '>=5' - dependencies: - eslint: 8.43.0 - eslint-visitor-keys: 2.1.0 - dev: true - /eslint-visitor-keys@1.3.0: resolution: { @@ -7017,14 +6914,6 @@ packages: engines: { node: '>=10' } dev: true - /eslint-visitor-keys@3.3.0: - resolution: - { - integrity: sha512-mQ+suqKJVyeuwGYHAdjMFqjCyfl8+Ldnxuyp3ldiMBFKkvytrXUZWaiPCEav8qDHKty44bD+qV1IP4T+w+xXRA==, - } - engines: { node: ^12.22.0 || ^14.17.0 || >=16.0.0 } - dev: true - /eslint-visitor-keys@3.4.1: resolution: { @@ -12542,17 +12431,6 @@ packages: } hasBin: true - /semver@7.3.8: - resolution: - { - integrity: sha512-NB1ctGL5rlHrPJtFDVIVzTyQylMLu9N9VICA6HSFJo8MCGVTMW6gfpicwKmmK/dAjTOrqu5l63JJOpDSrAis3A==, - } - engines: { node: '>=10' } - hasBin: true - dependencies: - lru-cache: 6.0.0 - dev: true - /semver@7.5.4: resolution: { From d1e47e2e7db1955242fa30cb86ab08145aca5f50 Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Fri, 19 Jan 2024 12:40:26 +0100 Subject: [PATCH 3/3] fix optional peer dep --- packages/web/package.json | 6 ++++-- pnpm-lock.yaml | 7 +++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/web/package.json b/packages/web/package.json index b9dc0ac..29cc44b 100644 --- a/packages/web/package.json +++ b/packages/web/package.json @@ -88,7 +88,9 @@ "peerDependencies": { "react": "^18" }, - "optionalDependencies": { - "react": "^18" + "peerDependenciesMeta": { + "react": { + "optional": true + } } } diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index bfdc3ae..3c75583 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -137,10 +137,6 @@ importers: server-only: specifier: ^0.0.1 version: 0.0.1 - optionalDependencies: - react: - specifier: ^18 - version: 18.2.0 devDependencies: '@swc/core': specifier: ^1.3.66 @@ -175,6 +171,9 @@ importers: jest-environment-jsdom: specifier: ^29.5.0 version: 29.5.0 + react: + specifier: ^18.2.0 + version: 18.2.0 react-dom: specifier: ^18.2.0 version: 18.2.0(react@18.2.0)