-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pnpm in README to selected package manager #6585
Comments
This could be as simple as modifying the README, or only including a template README with placeholders that gets processed by |
Agreed, I think this could be a really nice first issue |
Hi Team, I feel interested in this good first issue and want to begin my open-source contribution with TurboRepo. Please let me know if this is the place where the feature is requested: with regards, |
@DependerKumarSoni yes, that's the right place along with the |
I think the best way to do this would be a new transformer here: https://github.com/vercel/turbo/tree/main/packages/create-turbo/src/transforms It could go into the package manager transformer as well, but I wouldn't be opposed to keeping that isolated and making a new, docs related transformer. |
@mehulkar Please let me know if I am thinking in the right direction:
|
@DependerKumarSoni, I'd recommend keeping your PR as small as possible. Let's focus it on getting the README transform done. We won't need to any more prompts than what create-turbo does today. The existing "Select a package manager" step should tell the transform how to update the README commands. The other work Mehul has mentioned has some design implications that I'd like to think about more deeply so let's keep that as future work. 👍 |
@DependerKumarSoni we already add the specified name to the root package.json for the basic example, so that doesn't need to be done. That's handled here: https://github.com/vercel/turbo/blob/main/packages/create-turbo/src/transforms/official-starter.ts#L56C20-L60 We discussed doing this for all examples, but originally decided against it. If we want to change that in the future it's a simple change here! |
I've made some changes to the code that I believe should work fine. Could you please guide me on how best to test it? |
@DependerKumarSoni Letting AI give a better answer than I probably could myself: https://sdk.vercel.ai/s/vMcNAHx 😄 |
Hi team, |
@DependerKumarSoni to test locally you can run |
@tknickman I tried running
Then I created a new git clone of my forked repo and ran the same command after pnpm install. Got this:
|
@tknickman |
Any update on this? I see the story label got removed, but when generating a new turbo repo with |
It looks like #6747 is close but has stalled. @DependerKumarSoni, are you still able to work on it? Apologies for the delays on our side. Tom is on parental leave! |
I have submitted a pull request addressing this issue: #9632. Please feel free to review it, and let me know if any further changes are needed. |
I think some kind of generator/transformer would be preferred instead of listing all possible options in the same codeblock. Something similar to @DependerKumarSoni 's PR |
I've made a pull request(#9633) which I think will resolve this issue. |
Which project is this feature idea for?
Turborepo
Describe the feature you'd like to request
Replace the pnpm commands in the README from the basic turborepo example (which is used by
npx create-turbo@latest
) with the selected package manager from the CLI commandDescribe the solution you'd like
Replace the pnpm commands in the README with the selected package manager
Describe alternatives you've considered
List commands for all package managers in the README
The text was updated successfully, but these errors were encountered: