Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow looping VGM's endlessly that do not have loop points? #40

Open
KynikossDragonn opened this issue Jun 5, 2018 · 6 comments
Open

Comments

@KynikossDragonn
Copy link

vgmplay seems to just stop\exit when it hits the EOF of a song that has no loop defined in the metadata, even with MaxLoops set to 0.

Could there be a way to add it so that it loops all VGM's regardless of there being a loop or not? Are there playback concerns to address adding this feature? (e.g. continuing notes already playing or sending resets, etc)

@ValleyBell
Copy link
Contributor

ValleyBell commented Jun 5, 2018

Making it work properly would definitely involve sending resets, else we would risk hanging notes. It shouldn't be too hard though.

The reason VGMPlay doesn't loop VGMs without loop metadata is, that it doesn't make sense to loop jingles. Every VGM that is supposed to loop should have a loop defined and every VGM that isn't should not.

It's an interesting suggestion though.

@KynikossDragonn
Copy link
Author

Some sets I listen to don't have loop points set and they're actually full songs that normally can loop in the games in question if you permit the song to reach that far ahead.

I suppose I could use the vgm tools to set the looping myself but having a simple true\false switch for always loop would be nice to have as a convenience for strange people like me that can listen to the same song for over 700 minutes.

@ValleyBell
Copy link
Contributor

Ah, okay.

What sets are those? Maybe they should be fixed.

@KynikossDragonn
Copy link
Author

Hexen (every ingame song is supposed to loop)
Tyrian 2000 (Tyrian, The Song can loop if you let it play long enough and does not count as a "jingle")

are two I can name, that I know is supposed to have complete looping. KGB, Dune (except for Too and Water) don't loop at all despite not being "jingles".

@superctr
Copy link
Contributor

superctr commented Jun 5, 2018 via email

@KynikossDragonn
Copy link
Author

I have absolutely no idea how to go about writing a plugin for Audacious (as I know extremely little C\C++ and I have a learning impairment that doesn't make it easy for me to learn) so I just go by using the command line player.

Surprisingly alot of the music I listen to is through commandline: adplay-unix, openmpt123, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants