Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new knative runners to remaining benchmarks #248

Open
9 of 16 tasks
dhschall opened this issue Aug 26, 2022 · 2 comments
Open
9 of 16 tasks

Apply new knative runners to remaining benchmarks #248

dhschall opened this issue Aug 26, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@dhschall
Copy link
Contributor

dhschall commented Aug 26, 2022

In #238 we implement a new workflow that use Github runners for CI testing.
However, the workflow is not implemented for all benchmarks yet:

The benchmarks and the once net to be done:

What needs to be done
Before applying the service create the knative cluster using kind:

## Setup a Knative cluster to test the service
  - name: Create k8s Kind Cluster
    run: bash ./runner/scripts/01-kind.sh

  - name: Install Serving
    run: bash ./runner/scripts/02-serving.sh

  - name: Install Kourier
    run: bash ./runner/scripts/02-kourier.sh

  - name: Setup domain
    run: |
      INGRESS_HOST="127.0.0.1"
      KNATIVE_DOMAIN=$INGRESS_HOST.sslip.io
      kubectl patch configmap -n knative-serving config-domain -p "{\"data\": {\"$KNATIVE_DOMAIN\": \"\"}}"

Make sure to user this versions to be consistent

    env:
      KIND_VERSION: v0.14.0
      K8S_VERSION: v1.23

Note: As the scripts only install kubectl but not kn one can only use kubectl commands to apply and interact with services.
Either add kn installation or use the respective kubectl command instead of kn. I.e. kubectl apply -f <> instead of kn service apply -f <>

@dhschall dhschall added the enhancement New feature or request label Aug 26, 2022
@ustiugov
Copy link
Member

@dhschall please create children Issues and assign them to the corresponding maintainers

@ustiugov
Copy link
Member

apparently, there is a workaround to run Eventing (and probably all other more complex knative setups) that removes all resource requests to k8s (which may not be possible to satisfy when running on a single GH runner with 3 CPU cores and little memory)

kubectl get deployment -n knative-serving -o yaml | yq 'del(.items[]?.spec.template.spec.containers[]?.resources)' | kubectl apply -f -
kubectl get deployment -n knative-eventing -o yaml | yq 'del(.items[]?.spec.template.spec.containers[]?.resources)' | kubectl apply -f -

As suggested in csantanapr/knative-kind#47 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants